ci(tests): fix tests and ci workflows #163
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambacha
commented
Feb 7, 2025
| @@ -1222,7 +1222,7 @@ test("trying to add message to store that isn't on allowlist", async (t) => { | |||
| }); | |||
|
|
|||
| test("adding message from too far into the future", async (t) => { | |||
| env.MAX_TIMESTAMP_DELTA_SECS = 60; | |||
There was a problem hiding this comment.
Fixes:
Type 'number' is not assignable to type 'string'
sambacha
commented
Feb 7, 2025
Comment on lines
+1
to
+15
| { | ||
| "compilerOptions": { | ||
| "module": "ESNext", | ||
| "moduleResolution": "Bundler", | ||
| "checkJs": true, | ||
| "target": "ES2022", | ||
| "allowImportingTsExtensions": true, | ||
| "strictNullChecks": true, | ||
| "strictFunctionTypes": true | ||
| }, | ||
| "exclude": [ | ||
| "node_modules", | ||
| "**/node_modules/*" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Dev:
This gives typechecking in VSCode Studio (it uses the typescript typechecker).
sambacha
commented
Feb 7, 2025
| @@ -0,0 +1,91 @@ | |||
| name: Docker build & push image | |||
There was a problem hiding this comment.
This will be needed in a forthcoming PR for doing E2E testing in ephemeral CI instances.
The reason being it will be much easier to track regressions and also we need the container env anyway for network tests.
sambacha
commented
Feb 7, 2025
| @@ -1,3 +1,9 @@ | |||
| root = true | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.