Skip to content

Remove explicit GITHUB_TOKEN passing in release workflow#24

Merged
lmangani merged 2 commits intocopilot/persist-user-preferencesfrom
copilot/update-github-actions-permissions
Jan 22, 2026
Merged

Remove explicit GITHUB_TOKEN passing in release workflow#24
lmangani merged 2 commits intocopilot/persist-user-preferencesfrom
copilot/update-github-actions-permissions

Conversation

Copy link
Contributor

Copilot AI commented Jan 22, 2026

Workflow now relies on automatic GITHUB_TOKEN context access rather than explicit environment variable passing for repository write operations.

Changes

  • .github/workflows/build-release.yml: Removed env.GITHUB_TOKEN from softprops/action-gh-release@v1 step

The workflow's permissions: contents: write declaration already scopes what the automatic token can access. Modern GitHub Actions convention is to let actions access the token from context rather than explicit passing.

Before/After

  - name: Upload to Release (if triggered by release)
    uses: softprops/action-gh-release@v1
    with:
      files: |
        AceForge-macOS.dmg
        AceForge-macOS.zip
        checksums.txt
-   env:
-     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Note: MACOS_SIGNING_IDENTITY secret remains unchanged—it's used for code signing, not repository access.

Original prompt

PR #23 modifies the GitHub Actions workflow. However, to ensure proper security compliance, the workflow must exclusively utilize GitHub's built-in permissions for writing to the repo. Review and modify the workflow in this PR to rely solely on the automatic permissions associated with the GITHUB_TOKEN or other built-in permissions.

This pull request was created from Copilot chat.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot AI changed the title [WIP] Modify GitHub Actions to use built-in permissions Remove explicit GITHUB_TOKEN passing in release workflow Jan 22, 2026
Copilot AI requested a review from lmangani January 22, 2026 14:30
@lmangani lmangani marked this pull request as ready for review January 22, 2026 14:31
@lmangani lmangani merged commit ff9cda1 into copilot/persist-user-preferences Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants