Skip to content

Add missing rotary-embedding-torch dependency for macOS builds#25

Merged
lmangani merged 3 commits intomainfrom
copilot/fix-macos-build-issues
Jan 22, 2026
Merged

Add missing rotary-embedding-torch dependency for macOS builds#25
lmangani merged 3 commits intomainfrom
copilot/fix-macos-build-issues

Conversation

Copy link
Contributor

Copilot AI commented Jan 22, 2026

PyInstaller's CDMF.spec references rotary_embedding_torch as a hidden import but the package was not installed, causing macOS build failures.

Changes

  • Added rotary-embedding-torch==0.8.9 to requirements_ace_macos.txt
  • Added rotary-embedding-torch==0.8.9 to requirements_ace.txt for consistency

The package is a transitive dependency of ACE-Step and required for proper PyInstaller bundling.

Original prompt

The failure in the macOS build contains several issues preventing completion. The resolution steps are outlined below:\n\n1. Missing Dependency:\n - The log indicates that rotary_embedding_torch is not installed, triggering PyInstall to raise:\n ```\n ERROR: Hidden import `rotary_embedding_torch\n ]

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issues preventing macOS build completion Add missing rotary-embedding-torch dependency for macOS builds Jan 22, 2026
Copilot AI requested a review from lmangani January 22, 2026 15:20
@lmangani lmangani marked this pull request as ready for review January 22, 2026 18:50
@lmangani lmangani merged commit 53741ad into main Jan 22, 2026
4 checks passed
@lmangani lmangani deleted the copilot/fix-macos-build-issues branch January 22, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants