Remove API url columns (that can be recalculated) from the contributors table#3747
Draft
Remove API url columns (that can be recalculated) from the contributors table#3747
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…espite this being less efficient Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
added
database
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this change removes 9 columns of API urls from the contributors table, including any data in instances (because this data is entirely determined by the repo path and can be recalculated if needed
I strongly suspect these urls are unused because many of them use an uncommon pattern to indicate what appears to be substitutions (i.e. some of them contain bits like
users/jimmy{/subscriptions}which would require specialized logic in order to actually use.These URLs came directly from the github API and are inserted into the DB when we perform contributor resolution.
The main benefit is that this helps save augur instances some space in one of the most commonly used tables
This is not an especially important/urgent PR, but I figured id file it in case other maintainers have time to review it.
NOTE: this pr does not remove any of the functionality in 8knot that inserts these URLs, so this PR shouldn't merge until after this is addressed (planned in the contributor resolution updates coming soon)
Risk
The risk of causing issues with this is:
Signed commits