reschedule clone_repos regardless of how many repos were found#3796
Open
reschedule clone_repos regardless of how many repos were found#3796
Conversation
… need cloning Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Collaborator
Author
|
i cant test this for a while, but it should be relatively easy to test |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #3321 - a bug where, especially on smaller instances, facade appears to not clone repos until the instance is restarted after core and facade are ready.
This was due to an indentation bug with the self-rescheduling behavior of this task where it only reschedules itself if it processed at least one repo.
given how this is implemented, we could maybe simplify it further by making this a properly scheduled task alongside the same lines as collection_monitor, rather than DIYing it
Notes for Reviewers
both the conversation in the issue and AI helped diagnose this issue but all code is human written
Signed commits