fix(resolvers): remove unusable asValue option of the factory decorator

aurelia · May 30, 2018 · 5739152 · 5739152
1 parent f09ff03
commit 5739152
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/doc/article/en-US/dependency-injection-basics.md b/doc/article/en-US/dependency-injection-basics.md
@@ -331,7 +331,7 @@ If using TypeScript, keep in mind that `@autoinject` won't allow you to use `Res
 * `all(key)`
 * `optional(checkParent?)`
 * `parent`
-* `factory(key, asValue?)`
+* `factory(key)`
 * `newInstance(asKey?, dynamicDependencies: [any])`
 
 Here's an example of how we might express a dependency on `HttpClient` that we may or may not actually need to use, depending on runtime scenarios:

diff --git a/src/resolvers.js b/src/resolvers.js
@@ -392,11 +392,10 @@ export function parent(target, key, index) {
 /**
 * Decorator: Specifies the dependency to create a factory method, that can accept optional arguments
 */
-export function factory(keyValue: any, asValue?: any) {
+export function factory(keyValue: any) {
   return function(target, key, index) {
     let inject = getDecoratorDependencies(target);
-    let factory = Factory.of(keyValue);
-    inject[index] = asValue ? factory.as(asValue) : factory;
+    inject[index] = Factory.of(keyValue);
   };
 }