Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTPS redirect URLs [SDK-4754] #417

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 8, 2024

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A) -> docs will be added in a follow up PR.

📋 Changes

This PR updates Auth0.swift to v2.6.0, and adds a new configuration option to opt into using HTTPS redirect URLs when performing web-based authentication.

🎯 Testing

Besides adding unit tests, the changes were tested manually with Xcode 15.3 (15E204a), on iOS 17.4 and 17.2, and macOS 14.4 and 14.3.1.

iOS 17.4 simulator

Screen.Recording.2024-03-08.at.21.06.07.mov

iOS 17.2 simulator

Screen.Recording.2024-03-08.at.21.07.35.mov

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (253209a) to head (dd43ce6).
Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #417      +/-   ##
============================================
+ Coverage     96.08%   96.34%   +0.25%     
============================================
  Files            97       98       +1     
  Lines          1611     1613       +2     
  Branches        331      348      +17     
============================================
+ Hits           1548     1554       +6     
- Misses           49       50       +1     
+ Partials         14        9       -5     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android 97.35% <ø> (+0.79%) ⬆️
auth0_flutter_ios 99.70% <100.00%> (-0.14%) ⬇️
auth0_flutter_platform_interface 87.06% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket merged commit 4a852b5 into main Mar 12, 2024
18 of 19 checks passed
@Widcket Widcket deleted the feature/https-callbacks branch March 12, 2024 16:58
@jira jira bot mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants