-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTTPS redirect URLs [SDK-4754] #417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
============================================
+ Coverage 96.08% 96.34% +0.25%
============================================
Files 97 98 +1
Lines 1611 1613 +2
Branches 331 348 +17
============================================
+ Hits 1548 1554 +6
- Misses 49 50 +1
+ Partials 14 9 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stevehobbsdev
approved these changes
Mar 12, 2024
This was referenced Mar 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR updates Auth0.swift to v2.6.0, and adds a new configuration option to opt into using HTTPS redirect URLs when performing web-based authentication.
🎯 Testing
Besides adding unit tests, the changes were tested manually with Xcode 15.3 (15E204a), on iOS 17.4 and 17.2, and macOS 14.4 and 14.3.1.
iOS 17.4 simulator
Screen.Recording.2024-03-08.at.21.06.07.mov
iOS 17.2 simulator
Screen.Recording.2024-03-08.at.21.07.35.mov