-
Notifications
You must be signed in to change notification settings - Fork 285
Add support for DPoP #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DPoP #869
Conversation
src/auth0-context.tsx
Outdated
| getDpopNonce: Auth0Client['getDpopNonce']; | ||
|
|
||
| /** | ||
| * Gets the current DPoP nonce used for making requests to Auth0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Gets the current DPoP nonce used for making requests to Auth0. | |
| * Sets the current DPoP nonce used for making requests to Auth0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
| */ | ||
| generateDpopProof: Auth0Client['generateDpopProof']; | ||
|
|
||
| createFetcher: Auth0Client['createFetcher']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is missing doc comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
EXAMPLES.md
Outdated
| > | ||
| > You decide how to handle this transition. For example, you might require users to log in again the next time they use your application. | ||
| > [!IMPORTANT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should probably be a NOTE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
EXAMPLES.md
Outdated
| > [!IMPORTANT] | ||
| > Using DPoP requires storing some temporary data in the user's browser. When you log the user out with `logout()`, this data is deleted. | ||
| > [!IMPORTANT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should probably be a TIP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
EXAMPLES.md
Outdated
| const { createFetcher } = useAuth0(); | ||
|
|
||
| const fetcher = createFetcher({ | ||
| fetch: (request) => signal: AbortSignal.timeout(2000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax here seems off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
**Added** - Add support for DPoP [\#869](#869) ([martinml](https://github.com/martinml))
### Description This PR adds support for DPoP via an update of `auth0-spa-js` from 2.3.0 to 2.4.1. New methods are exposed, docs are updated. No logic changes. ### Testing - [x] This change adds test coverage for new/changed/fixed functionality ### Checklist - [x] I have added documentation for new/changed functionality in this PR or in auth0.com/docs - [x] All active GitHub checks for tests, formatting, and security are passing - [x] The correct base branch is being used, if not the default branch --------- Co-authored-by: Rita Zerrizuela <[email protected]> Co-authored-by: Gyanesh Gouraw <[email protected]>
**Added** - Add support for DPoP [\#869](#869) ([martinml](https://github.com/martinml))
**Added** - Add support for DPoP [\#869](auth0/auth0-react#869) ([martinml](https://github.com/martinml))
Description
This PR adds support for DPoP via an update of
auth0-spa-jsfrom 2.3.0 to 2.4.1.New methods are exposed, docs are updated. No logic changes.
Testing
Checklist