Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named exports in esm modules #815

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

perrin4869
Copy link

@perrin4869 perrin4869 commented Mar 8, 2022

Description

This PR adds the ability to use named exports in type: module node environments:

import { sign } from "jsonwebtoken";

It accomplishes this via https://github.com/nodejs/cjs-module-lexer

Testing

I added a test for this - unfortunately it will fail the lint parsing because it still supports node versions < 12.
Once the linting is updated, the tests will pass in all node >= 12.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@perrin4869
Copy link
Author

@jakelacey2012 any chance you can take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant