Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues 905: Update package.json SEMVER 7.5.4 #919

Closed
wants to merge 3 commits into from

Conversation

SEKERM
Copy link

@SEKERM SEKERM commented Jul 4, 2023

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

Copy link

@moddx moddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SEKERM SEKERM requested a review from moddx July 12, 2023 07:20
@moddx
Copy link

moddx commented Jul 12, 2023

Maybe @jakelacey2012 could approve this?

@ashrash
Copy link

ashrash commented Jul 19, 2023

Any update on when will this be pushed ?

@SEKERM
Copy link
Author

SEKERM commented Jul 24, 2023

@jakelacey2012 can you please take over at this point?

@SEKERM SEKERM changed the title issues 905: Update package.json SEMVER 7.5.3 issues 905: Update package.json SEMVER 7.5.4 Jul 24, 2023
@SEKERM SEKERM requested a review from fang2hou July 24, 2023 07:49
@RDarnel
Copy link

RDarnel commented Jul 24, 2023

Are there any updates on getting a final approval for this PR?

Copy link

@fang2hou fang2hou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have tested all the use cases in node-jsonwebtoken, comparing the results between semver 7.3.8 and semver 7.5.4. There is no differences I found.

@dragan-novakovic
Copy link

Hi @moddx any updates on this?

@visnicka
Copy link

hey guys, thanks for the hard work!
is there a chance we could get update on the estimated time of fix?

@moddx
Copy link

moddx commented Jul 25, 2023

Hey @dragan-novakovic ,
I'm not part of auth0 and don't have write access to the repository.

Judging by the sheer number of open PRs the repo seems pretty neglected..

Maybe @woloski could delegate this to someone?

@SEKERM
Copy link
Author

SEKERM commented Jul 30, 2023

Merging is blocked
Merging can be performed automatically with 1 approving review. <<

@SEKERM
Copy link
Author

SEKERM commented Jul 31, 2023

@moddx can you approve again?

Review required
At least 1 approving review is required by reviewers with write access.
1 pending reviewer
@moddx
moddx was requested for review

@moddx
Copy link

moddx commented Jul 31, 2023

@moddx can you approve again?
Review required At least 1 approving review is required by reviewers with write access.

I could, but it doesnt matter, because i dont have right accces

@didaquis
Copy link

I just wrote an email to Auth0 to ask them to pay attention to this merge request

@didaquis
Copy link

didaquis commented Aug 4, 2023

No one has responded to the email I sent. ☹️

@tietthinh
Copy link

Any update on this PR?

1 similar comment
@Hyjaz
Copy link

Hyjaz commented Aug 17, 2023

Any update on this PR?

@SEKERM
Copy link
Author

SEKERM commented Aug 18, 2023

@CharlesRea @ArturKlajnerok pls provide an update on this due to criticality.

@mkrudele
Copy link

When will this PR be merged and a new version of the module published?

@SEKERM
Copy link
Author

SEKERM commented Aug 28, 2023

When will this PR be merged and a new version of the module published?

Please follow up the repo owners PR:
#932

@SEKERM SEKERM closed this Aug 29, 2023
@SEKERM SEKERM deleted the patch-1 branch August 29, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.