Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit event from component usage #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Inherit event from component usage #21

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2018

resolve #20 events emitting
update dev server base path

@AlexandreBonneau AlexandreBonneau self-assigned this Jun 14, 2018
@ghost
Copy link
Author

ghost commented Jun 19, 2018

@AlexandreBonneau maybe you have any comments on this PR or suggestions how this should be implemented? Or there is something more that I need to do to approve this PR?

Thanks

@AlexandreBonneau
Copy link
Member

This looks great @AndriusZid, I'll just check if this does not introduce any regressions and should merge this soon™ 😎

@AlexandreBonneau
Copy link
Member

@AndriusZid unfortunately this PR breaks the component.

You can check the vue-autoNumeric/examples/index.html file and see that the rawValue is never updated anymore, and therefore the other component using the same model aren't updated too.

@ghost
Copy link
Author

ghost commented Mar 27, 2019

Hi @AlexandreBonneau I have updated PR with a different approach and that one covers only blur event. Please let me know what you think :)

@mjeanrichard
Copy link

@AlexandreBonneau Could you have a look at this? I need this as well in order to use the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherit events from component wrapper
2 participants