Skip to content

Fix webpack error handling in GDU build process #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix webpack error handling in GDU build process #332

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46c94db
Initial plan for issue
Copilot Jun 4, 2025
2234147
Fix webpack error handling in runWebpack.ts
Copilot Jun 4, 2025
872cb18
Remove duplicate console error output in webpack error handling
Copilot Jun 4, 2025
9a3db28
Add changeset for GDU webpack error handling fix
Copilot Jun 4, 2025
f3a474b
Update fix-webpack-error-handling.md
skinread Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/gdu/lib/runWebpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ const debug = bugger('gdu:webpack:compile');

const done = (resolve, reject) => (err, stats) => {
if (err || stats.hasErrors()) {
reject(err || stats.toString('errors-only'));
const errorMessage = err || stats.toString('errors-only');
console.error('Webpack compilation failed:');
console.error(errorMessage);
reject(errorMessage);
return;
}

Expand All @@ -29,10 +32,10 @@ export const run = async (compiler: Compiler | MultiCompiler) =>
new Promise((resolve, reject) =>
compiler.run((err, stats) => {
compiler.close((err2) => {
console.log(stats);
resolve(err || err2);
// Handle compilation errors first, then close errors
const combinedError = err || err2;
done(resolve, reject)(combinedError, stats);
});
done(resolve, reject);
}),
);

Expand Down