This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Add sentry support #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabmontes
reviewed
Feb 20, 2018
public/electron.js
Outdated
| @@ -42,7 +59,7 @@ createWindow() | |||
| const { initMainWorker } = require(path.join(__dirname, './main/mainWorker.js')) | |||
|
|
|||
| app.on('ready', function() { | |||
| logger.info('App ready, initlilizing...') | |||
| logger.info('App ready, initializing 🚀') | |||
There was a problem hiding this comment.
Nice rocket but prefer plain text in logs. Don't want to shut remote loggers down with Unicode chars. Please remove it.
There was a problem hiding this comment.
where could it represent a problem?
src/index.js
Outdated
|
|
||
| if (config.SENTRY_DSN) { | ||
| Raven.config( | ||
| 'https://[email protected]/277183' |
There was a problem hiding this comment.
This should be taken from config.SENTRY_DSN.
|
@ianaya89 did you cancel this PR? |
eafelix
suggested changes
Feb 21, 2018
public/electron.js
Outdated
| @@ -42,7 +59,7 @@ createWindow() | |||
| const { initMainWorker } = require(path.join(__dirname, './main/mainWorker.js')) | |||
|
|
|||
| app.on('ready', function() { | |||
| logger.info('App ready, initlilizing...') | |||
| logger.info('App ready, initializing 🚀') | |||
There was a problem hiding this comment.
where could it represent a problem?
eafelix
approved these changes
Feb 21, 2018
gabmontes
approved these changes
Feb 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50