Add a timeout to inbound libp2p-kad substreams#29
Add a timeout to inbound libp2p-kad substreams#29teor2345 wants to merge 1 commit intosubspace-v9from
Conversation
|
This PR is unnecessary, IIRC libp2p version is already overridden in https://github.com/autonomys/subspace and we don't really use this repo outside of that. This is only needed if there are breaking changes to libp2p API, but looks like there were none here. |
Only Subspace needs the We can override all the |
Then I believe it should be possible to add another override for
It was probably a related, but different situation. We override frontier for the same reason, for example. This is much more productive than maintaining a fork as long as we don't do breaking changes to Substrate itself (as far as frontier libraries are concerned of course). |
3 crates need to be patched, and the patch only works because You usually can't patch one crate version with another version, you have to change the crate fork/source as well. |
This PR upgrades the
libp2pversion in our fork to autonomys/rust-libp2p#2It adds an inbound substream timeout to the kad protocol, which matches the outbound substream timeout. This prevents "substream limit exceeded" errors under load, caused by the outbound side timing out, but the inbound side keeping on waiting.
See that PR for full details.
This PR is marked as draft, because the git commit hash will change when we merge the PR in our fork.