iface_option: Fix int() argument must be a string, a bytes-like object or a number, not NoneType #6529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t or a number, not NoneType Add fallback parser for ethtool -l and guard against int(None) If utils_net.get_channel_info() returns empty, parse Combined from ethtool -l <iface> via regex (no header dependency). Use first Combined as max, second as current (fallback to first if only one). Explicitly error if Combined can’t be parsed. Committer: Bolatbek Issakh <[email protected]>
Author
|
Before fix After fix |
Contributor
|
@BulaYoungR please double check this problem still exists. if not, let's close this PR. |
Contributor
|
@BulaYoungR how about this one? |
Contributor
|
It was already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallback parser for ethtool -l and guard against int(None) If utils_net.get_channel_info() returns empty, parse Combined from ethtool -l via regex (no header dependency). Use first Combined as max, second as current (fallback to first if only one). Explicitly error if Combined can’t be parsed.
Committer: Bolatbek Issakh [email protected]