Add new subfunction for gen17 on s390x #4378
Conversation
CPU: add new subfunctions msa13,msa11,msa10 to tests on s390x, remove the unsupported gen16 cpu model on RHEL7 Signed-off-by: bfu [email protected]
fbq815
force-pushed
the
KVMAUTOMA-3939
branch
from
2e1e5f3 to
27f94e6
Compare
|
RHEL9: RHEL10: |
There was a problem hiding this comment.
Hi @fbq815 Thanks for this.
Your commit message says "add new subfunctions msa13,msa11,msa10 to tests on s390x" but I don't see any change about this specifically. Can you please clarify?
There are also some minor nitpicks, please check my comments. Please keep also in mind the avocado styleguide for your commit message and header - https://avocado-framework.readthedocs.io/en/latest/guides/contributor/chapters/styleguides.html#commit-style-guide
Rest LGTM, thanks.
| cpu_model_check_args = '{"type": "static", "model": {"name": "host"}}' | ||
| RHEL.7: | ||
| boot_cpu_models = 'z196,z196.2,z114;zEC12,zEC12.2,zBC12;z13,z13.2,z13s;z14,z14.2,z14ZR1;gen15a,gen15b;gen16a,gen16b' | ||
| boot_cpu_models = 'z196,z196.2,z114;zEC12,zEC12.2,zBC12;z13,z13.2,z13s;z14,z14.2,z14ZR1;gen15a,gen15b' |
There was a problem hiding this comment.
I'm not a native English speaker but I think your commit message can be misunderstood
remove the unsupported gen16 cpu model on RHEL7
I think it would be clearer to say something like
RHEL 7 doesn't support cpu models after gen15, remove gen16.
| required_qemu = (7.1.0,) | ||
| cpu_models = "gen16a gen16b" | ||
| props = 'nnpa=True aen=True vxpdeh=True aefsi=True mepoch=True msa9=True msa8=True msa7=True msa6=True msa5=True msa4=True msa3=True msa2=True msa1=True sthyi=True edat=True ri=True deflate=True edat2=True etoken=True vx=True ipter=True pai=True paie=True mepochptff=True vxeh=True vxpd=True esop=True msa9_pckmo=True vxeh2=True iep=True cte=True gs=True ppa15=True zpci=True rdp=True sea_esop2=True beareh=True te=True cmm=True vxpdeh2=True' | ||
| - model_type_gen17a_gen17b_with_paie: |
There was a problem hiding this comment.
Why is this called with_paie, is there an alternative, does gen17a/b work without pai? What does that mean? Can you add the answer to your commit message?
3 participants
CPU: add new subfunctions msa13,msa11,msa10 to tests on s390x, remove the unsupported gen16 cpu model on RHEL7
ID: 3939
Signed-off-by: bfu [email protected]