Skip to content

docs: update the planning sim demo images#634

Closed
vish0012 wants to merge 3 commits intoautowarefoundation:mainfrom
vish0012:updoc_vishal
Closed

docs: update the planning sim demo images#634
vish0012 wants to merge 3 commits intoautowarefoundation:mainfrom
vish0012:updoc_vishal

Conversation

@vish0012
Copy link

@vish0012 vish0012 commented Dec 16, 2024

Description

The images in tutorials pages were using old RVIZ plugins. This PR updates the page with the latest RVIZ view to have less confusion to the users following the page.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r
Copy link
Member

mitsudome-r commented Dec 18, 2024

@vish0012
Could you update your PR title and description so that reviewers could understand what this PR is about?
I know it's mainly for updating images with the latest rviz, but it would be nice if you can update them for best practice.

@mitsudome-r mitsudome-r self-requested a review December 18, 2024 05:29
@mitsudome-r mitsudome-r changed the title Updoc vishal docs: update images in the tutorial pages Dec 19, 2024
@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Feb 17, 2025
Created by: Vishal Chauhan @vish0012
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@autowarefoundation autowarefoundation deleted a comment from stale bot Dec 2, 2025
@xmfcx xmfcx self-requested a review December 2, 2025 10:29
@xmfcx xmfcx added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 2, 2025
@xmfcx
Copy link
Contributor

xmfcx commented Dec 2, 2025

Hi @vish0012 thanks for your contribution!

image

Why are all the new images are duplicated into others page? I wish you had changed them.

I will now have to manually replace them one by one 😞

@xmfcx xmfcx changed the title docs: update images in the tutorial pages docs: update the planning sim demo images Dec 2, 2025
@xmfcx
Copy link
Contributor

xmfcx commented Dec 2, 2025

Also for the next time, please avoid spaces in filenames like these and follow dash-case like the rest of the documentation.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
Copy link
Contributor

xmfcx commented Dec 2, 2025

@xmfcx xmfcx closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants