Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move autoware_map_projection_loader package from Autoware Universe #125

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mitsudome-r
Copy link
Member

Description

This ports autoware_map_projection_loader package from Autoware Universe to Core.
There are some additional modifications added in the package to remove dependency to Universe:

  • change package dependency from autoware_interface_utils to autoware_core_interface_specs
  • Use autoware::core_component_interface_specs::map::MapProjectorInfo instead of autoware::component_interface_specs::map::MapProjectorInfo

This must be merged after #124.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Dec 16, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@liuXinGangChina liuXinGangChina added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 13, 2025
@xmfcx xmfcx added the type:moving Temporary label to represent packages that are specifically moving from Universe to Core. label Feb 26, 2025
@mitsudome-r mitsudome-r force-pushed the port-map-projection-loader branch from b50f6ad to e98fe95 Compare March 12, 2025 04:53
@mitsudome-r mitsudome-r force-pushed the port-map-projection-loader branch from e98fe95 to ae54a9f Compare March 12, 2025 10:20
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 68.25397% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.69%. Comparing base (4cb18f5) to head (ae54a9f).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
...ap_projection_loader/src/map_projection_loader.cpp 73.17% 9 Missing and 2 partials ⚠️
...jection_loader/src/load_info_from_lanelet2_map.cpp 59.09% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   78.75%   69.69%   -9.06%     
==========================================
  Files          11        3       -8     
  Lines         193       66     -127     
  Branches       73       43      -30     
==========================================
- Hits          152       46     -106     
- Misses         11       15       +4     
+ Partials       30        5      -25     
Flag Coverage Δ
differential 69.69% <68.25%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:moving Temporary label to represent packages that are specifically moving from Universe to Core.
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants