Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_trajectory): use move semantics and return expected<T, E> for propagating failure reason #254

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 10, 2025

Description

see the diff here: tier4/autoware.core@tier4:autoware.core:refactor/trajectory-class...feat/trajectory-class-refactor

depends #255

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Mar 10, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the feat/trajectory-class-refactor branch from 1a08627 to ac80fbc Compare March 11, 2025 02:04
@soblin soblin changed the title feat(autoware_trajectory): use nodiscard for mutable function, fix reference to scalar type, use move semantics, return result feat(autoware_trajectory): use move semantics and return expected<T, E> for propagating failure reason Mar 11, 2025
@soblin soblin force-pushed the feat/trajectory-class-refactor branch 2 times, most recently from cd577d0 to 8ab0ed8 Compare March 11, 2025 04:27
soblin added 8 commits March 12, 2025 13:17
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
This reverts commit 7b63d56.
@soblin soblin force-pushed the feat/trajectory-class-refactor branch from 2e5151e to f084050 Compare March 12, 2025 04:20
@soblin soblin marked this pull request as ready for review March 12, 2025 04:22
@soblin soblin requested review from takayuki5168, yhisaki and a team as code owners March 12, 2025 04:22
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 55.23810% with 47 lines in your changes missing coverage. Please review.

Project coverage is 25.62%. Comparing base (4cb18f5) to head (f084050).
Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
...ommon/autoware_trajectory/src/trajectory_point.cpp 40.90% 6 Missing and 7 partials ⚠️
common/autoware_trajectory/src/path_point.cpp 40.00% 5 Missing and 4 partials ⚠️
common/autoware_trajectory/src/point.cpp 30.00% 4 Missing and 3 partials ⚠️
common/autoware_trajectory/src/pose.cpp 44.44% 3 Missing and 2 partials ⚠️
...re_trajectory/include/autoware/trajectory/pose.hpp 0.00% 4 Missing ⚠️
...utoware_trajectory/src/path_point_with_lane_id.cpp 42.85% 2 Missing and 2 partials ⚠️
...erpolator/detail/interpolator_common_interface.hpp 40.00% 2 Missing and 1 partial ⚠️
...jectory/interpolator/detail/interpolator_mixin.hpp 75.00% 1 Missing ⚠️
...nclude/autoware/trajectory/interpolator/result.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #254       +/-   ##
===========================================
- Coverage   78.75%   25.62%   -53.13%     
===========================================
  Files          11       88       +77     
  Lines         193     3781     +3588     
  Branches       73      993      +920     
===========================================
+ Hits          152      969      +817     
- Misses         11     2702     +2691     
- Partials       30      110       +80     
Flag Coverage Δ
differential 25.62% <55.23%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant