Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): remove maximum drivable area visualization #5963

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 26, 2023

Description

Remove maximum drivable area visualization as it is not used anymore

#5825

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 26, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc1d483) 15.29% compared to head (2a59b69) 15.27%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5963      +/-   ##
==========================================
- Coverage   15.29%   15.27%   -0.02%     
==========================================
  Files        1750     1750              
  Lines      120566   120504      -62     
  Branches    36783    36739      -44     
==========================================
- Hits        18437    18411      -26     
+ Misses      81464    81460       -4     
+ Partials    20665    20633      -32     
Flag Coverage Δ *Carryforward flag
differential 11.69% <ø> (?)
total 15.27% <ø> (-0.02%) ⬇️ Carriedforward from cc1d483

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 8a9f43d into autowarefoundation:main Dec 26, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the remove-maximum-drivable-area branch December 26, 2023 10:55
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
@tfnh621
Copy link

tfnh621 commented Mar 12, 2025

Hi, does anyone know why this was removed or why?
I was reading the documentation on the design of the driveable area and noticed that the markers were not existing and found this PR.

### Visualizing maximum drivable area (Debug)
Sometimes, the developers might get a different result between two maps that may look identical during visual inspection.
For example, in the same area, one can perform avoidance and another cannot. This might be related to the maximum drivable area issues due to the non-compliance vector map design from the user.
To debug the issue, the maximum drivable area boundary can be visualized.
![drivable_area_boundary_marker1](../images/drivable_area/drivable_area_boundary_marker_example1.png)
![drivable_area_boundary_marker2](../images/drivable_area/drivable_area_boundary_marker_example2.png)
The maximum drivable area can be visualize by adding the marker from `/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/maximum_drivable_area`

| ~/debug/maximum_drivable_area | `visualization_msgs::msg::MarkerArray` | Shows maximum static drivable area | `volatile` |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants