Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update sync-param-files.yaml #111

Closed
wants to merge 2 commits into from
Closed

chore: update sync-param-files.yaml #111

wants to merge 2 commits into from

Conversation

awf-autoware-bot[bot]
Copy link
Contributor

@awf-autoware-bot awf-autoware-bot bot commented Nov 11, 2022 •
edited
Loading

No description provided.

@awf-autoware-bot awf-autoware-bot bot enabled auto-merge (squash) November 11, 2022 00:10
@awf-autoware-bot awf-autoware-bot bot force-pushed the update-sync-param-files branch 7 times, most recently from b24d63b to 7d8e1a0 Compare November 18, 2022 00:08
@awf-autoware-bot awf-autoware-bot bot force-pushed the update-sync-param-files branch 8 times, most recently from a4932e5 to e682372 Compare November 26, 2022 00:07
@awf-autoware-bot awf-autoware-bot bot force-pushed the update-sync-param-files branch 8 times, most recently from 3f41fb9 to 46b4a7a Compare December 4, 2022 00:08
@awf-autoware-bot awf-autoware-bot bot force-pushed the update-sync-param-files branch 6 times, most recently from 1397ece to 8c5fc29 Compare December 10, 2022 00:07
@awf-autoware-bot awf-autoware-bot bot force-pushed the update-sync-param-files branch 5 times, most recently from 45bf913 to 3e6202f Compare February 4, 2023 00:07
@awf-autoware-bot awf-autoware-bot bot force-pushed the update-sync-param-files branch 5 times, most recently from a702dca to dd1b19a Compare February 9, 2023 00:08
@kenji-miyake
Copy link
Contributor

kenji-miyake commented Feb 9, 2023 •
edited
Loading

@kminoda @takayuki5168 Could you tell me your plans for this sync of param files?

@kenji-miyake kenji-miyake marked this pull request as draft February 9, 2023 11:22
auto-merge was automatically disabled February 9, 2023 11:22

Pull request was converted to draft

@kminoda
Copy link
Contributor

kminoda commented Feb 9, 2023

@kenji-miyake (cc: @takayuki5168 )
Ideally we would like to use this workflow as a sync from Node Param to Launch Param.
But I think we can temporarily remove this workflow (no longer necessary for now, right?), since it may take some time to apply the above modification.

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Feb 9, 2023 •
edited
Loading

@kminoda Thank you for your quick reply.
I think it's okay if everyone knows the flow of the operation (need to sync parameter files manually for now?).
How about creating an issue of updating the workflow, for tracking? And write the flow there to let everyone know.

@kminoda
Copy link
Contributor

kminoda commented Feb 10, 2023

@kenji-miyake Right, thanks. I create an issue: #201

@kenji-miyake
Copy link
Contributor

@kminoda Thank you! And will you stop the workflow and close this issue?

@kenji-miyake
Copy link
Contributor

I assume so. Please reopen it if there is any issue.

@kenji-miyake kenji-miyake deleted the update-sync-param-files branch February 10, 2023 02:53
@kminoda
Copy link
Contributor

kminoda commented Feb 10, 2023

@kenji-miyake OK, but how can I stop the workflow? (Should I just delete the update-sync-param-files workflow related files?)

@kenji-miyake
Copy link
Contributor

@kminoda I stopped it from this page: https://github.com/autowarefoundation/autoware_launch/actions/workflows/update-sync-param-files.yaml
image

@kminoda kminoda mentioned this pull request Feb 13, 2023
Merged
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Oct 31, 2023
@kenji-miyake @xmfcx
ci: add stale.yml for probot/stale (autowarefoundation#111)
4ec68a6 
* ci: add stale.yml for probot/stale

Signed-off-by: Kenji Miyake <[email protected]>

* add a comment

Signed-off-by: Kenji Miyake <[email protected]>

* Update .github/stale.yml

Co-authored-by: M. Fatih Cırıt <[email protected]>

* Update stale.yml

Co-authored-by: M. Fatih Cırıt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@kminoda kminoda Awaiting requested review from kminoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenji-miyake @kminoda