Treat duplicate additions to the mempool as a noop #4622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Part of #4621
The reason why we reported an error upon a duplicate addition was previously to avoid pushing transactions that were already known.
This mechanism is no longer used, as it depended on additional behavior of the mempools which weren't implemented by the C-chain mempool. The entire gossip algorithm was changed to avoid these assumptions (around duplicate addition), but much of the code stayed around.
How this works
Self descriptive.
How this was tested
Existing tests
Need to be documented in RELEASES.md?