Update coreth to hash that exists #4634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the coreth dependency version in go.mod from a non-existent grafted version to a valid commit hash, enabling avalanchego to be used as a dependency by other projects.
Key Changes:
- Updated coreth version reference from
v0.16.0-rc.0to a valid commit hashv0.0.0-20251201152440-a263a7cedcd0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonathanOppenheimer
approved these changes
Dec 1, 2025
Member
JonathanOppenheimer
left a comment
JonathanOppenheimer
left a comment
There was a problem hiding this comment.
laughing at the PR name
maru-ava
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently, it is not possible to use avalanchego as a dependency, because the go.mod references a grafted coreth version that doesn't exist.
How this works
The coreth version in the go.mod isn't actually used for local builds, because of the replace directive. However, when other libraries attempt to fetch avalanchego, they do not honor the replace directive. This means that they will attempt to fetch the version of coreth in our go.mod, which doesn't exist.
How this was tested
I was able to update subnet-evm to this version of avalanchego after updating this reference.
Need to be documented in RELEASES.md?
no