ACP-226: Make MinDelayExcess Configurable #1246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
force-pushed
the
ceyonur/acp-226-genesis-configuration
branch
from
9ef4ceb to
56c96a2
Compare
| *headerExtra.MinDelayExcess = 0 // TODO: decide whether we want this to be configurable by genesis/chainconfig | ||
| headerExtra.MinDelayExcess = g.MinDelayExcess | ||
| if headerExtra.MinDelayExcess == nil { | ||
| headerExtra.MinDelayExcess = utils.NewUint64(acp226.InitialDelayExcess) |
There was a problem hiding this comment.
Is it desired for MinDelayExcess to ever by InitialDelayExcess? It seems like MinDelayExcess should be whatever excess puts the minimum minimumBlockDelay at 1 ms, and that MinDelayExcess = InitialDelayExcess would mean that the minimumBlockDelay can never decrease below the initial delay set
There was a problem hiding this comment.
not sure I fully understood what you mean. This sets it to default (2 secs) in the genesis. We still need to take care this in the block building. This only ensures new chains will be starting with 2 secs (from comment here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
acp226packageMinDelayExcessshould be configurable especially for L1sCloses: #1243
How this works
Adds
MinDelayExcessto genesis spec so it can be marshaled and set in the genesis header.How this was tested
added tests
Need to be documented?
no (at least not for C-chain)
Need to update RELEASES.md?
updated