Replay fix for Validator Manager #743
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
commented
Mar 18, 2025
Comment on lines
+533
to
+535
| ) internal returns (bytes32) { | ||
| (bytes32 validationID, bytes memory registerL1ValidatorMessage) = ValidatorMessages | ||
| .packRegisterL1ValidatorMessage( |
There was a problem hiding this comment.
Unrelated fix that simplified this code :)
geoff-vball
requested review from
iansuvak,
richardpringle,
bernard-avalabs,
michaelkaplan13,
cam-schultz and
mdelle1
| @@ -94,7 +94,7 @@ contract ValidatorManager is Initializable, OwnableUpgradeable, ACP99Manager { | |||
| 0xe92546d698950ddd38910d2e15ed1d923cd0a7b3dde9e2a6a3f380565559cb00; | |||
|
|
|||
| uint8 public constant MAXIMUM_CHURN_PERCENTAGE_LIMIT = 20; | |||
| uint64 public constant MAXIMUM_REGISTRATION_EXPIRY_LENGTH = 2 days; | |||
| uint64 public constant MAXIMUM_REGISTRATION_EXPIRY_LENGTH = 1 days; | |||
There was a problem hiding this comment.
Is this change required for this fix?
There was a problem hiding this comment.
Not required, no, but aligns with the value the p-chain uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes an issue where:
expiryof original message.initiateValidatorRegistrationmessage.completeValidatorRegistrationmessage signed by p-chainThis could cause a validator to be marked as active in the contract, but inactive on the p-chain. Such a validator would not be able to accrue any
uptime, so in most cases would be ineligible for rewards. We want to avoid potential de-syncs from with the p-chain.Also aligns
MAXIMUM_REGISTRATION_EXPIRY_LENGTHto be equal to the value on the p-chain.How this works
Since we keep validator state indefinitely, we just check if the status is
Unknownbefore initiating a registration.How this was tested
How is this documented