Determine Priority Annotations at Compile Time #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- read the annotations at compile time - simplify bean matching logic - can use priority on factory beans now
SentryMan
changed the title
rbygrave
reviewed
Jul 13, 2025
rbygrave
reviewed
Jul 13, 2025
| @@ -526,7 +533,7 @@ boolean isLazy() { | |||
| } | |||
|
|
|||
| boolean isUseProviderForSecondary() { | |||
| return secondary && !optionalType && !Util.isProvider(returnTypeRaw); | |||
| return (secondary || priority != null) && !optionalType && !Util.isProvider(returnTypeRaw); | |||
There was a problem hiding this comment.
So if it's got a @Priority also wire as Provider<T> which has the effect of only instantiating when needed.
Needed by .. being the highest priority or BeanScope#list or injecting a List/Set/Map of that type.
There was a problem hiding this comment.
Indeed, the appearance of a priority annotation invites the possibility that a higher priority bean might exist
rbygrave
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Priorityannotations at compile time@Primary/@Secondarybeans@Priorityon factory@BeanmethodsResolves #854