Use FilterOutputStream in Output Buffer
#294
Merged
+17
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SentryMan
force-pushed
the
FilterOutputStream
branch
3 times, most recently
from
2dbefdd to
60899ef
Compare
SentryMan
force-pushed
the
FilterOutputStream
branch
from
60899ef to
bb2dcec
Compare
What is the benefit? It isn't clear to me what is "neat"? |
|
Saves like three lines of code, the only other thing of note is how we don't check the stream is null on every write |
rbygrave
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just think it's neat