Mentions: Fix to get span instead of a back when href property exists, but has no value #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverything
changed the title
This reverts commit 86d92f8.
Owner
|
Thanks for the work on this. Can you make the mentions in the factory a state modifier and also verify the tests pass if no mentions are used at all. |
Contributor
Author
|
@awcodes, yes, I'll give it a shot. Initially, I just wanted to resolve the issue with Mentions always rendering as links. |
Owner
|
Thank you for being willing to work on it. I get exactly what you are trying to fix, but i'm concerned that it broke the tests, since mentions are opt in. There could be an underlying issue that needs to be solved. |
Contributor
Author
|
@awcodes yes, you are correct. I'll need some more time fixing the tests and updating them, but I'll keep you posted. |
Owner
|
No rush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.