Skip to content

Conversation

@slizhva
Copy link
Contributor

@slizhva slizhva commented Sep 16, 2025

public function convertCount(string|int|float $number): string
{
    if (OverlookPlugin::get()->shouldAbbreviateCount()) { // <== false <== OverlookPlugin::make()->abbreviateCount(false)
        return Number::abbreviate((int) $number);
    }

    return $number; // expected to be string per function definition, but string|int|float returned.
}

@awcodes awcodes merged commit c808d45 into awcodes:3.x Sep 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants