Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly handle non backend outputs from stack metadata #2537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtpascual
Copy link
Contributor

Problem

Using CDK nag or doing backend.stack.addMetadata() causes ZodError when generating the amplify_outputs.json file. The ZodError is occurring when we are parsing the stack metadata in order to fetch backend outputs and the parsing is not expecting non backend output entries.

Issue number, if available:

Changes

Filter out non backend output entries in stack metadata before parsing.

Corresponding docs PR, if applicable:

Validation

Unit tests

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rtpascual rtpascual requested review from a team as code owners February 25, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant