feat(rtn-web-browser): add auth support for chromebook #14523
+140
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamouda78
requested review from
pranavosu,
Amplifiyer and
avi-karthik
as code owners
6 tasks
pranavosu
previously approved these changes
Aug 28, 2025
Co-authored-by: Ahmed Hamouda <[email protected]>
soberm
reviewed
Sep 4, 2025
| mockPlatform.OS = 'ios'; | ||
| }); | ||
|
|
||
| describe('isChromebook', () => { |
There was a problem hiding this comment.
Should we also add tests for the other cases?
| functions: 100, | ||
| lines: 100, | ||
| statements: 100, | ||
| branches: 25, |
There was a problem hiding this comment.
Why reduce the coverage thresholds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds authentication support for Chromebook devices in the
rtn-web-browserpackage. The changes include:isChromebook()function to detect Chromebook devices using Expo Device API and native ChromeOS moduleopenAuthSessionChromeOs()function to handle auth sessions on Chromebook usingLinking.openURL()instead of native browser tabsopenAuthSessionAsync()to detect Chromebook devices and route to the appropriate auth session handlerIssue #, if available
#14459
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.