Skip to content

Conversation

bobbor
Copy link
Member

@bobbor bobbor commented Aug 27, 2025

Description of changes

Improving the api URL resolution in case of relative URL's to include the locations origin
also fixing a false positive in the tests of the publicApi's

Issue #, if available

Amplify 6 - Cannot use a url relative url for the Rest API Endpoint url #13031

Description of how you validated changes

I have added tests to actually test the resolve URL. This includes tests for

  • absolute URL's
  • relative URL's
  • url's without protocol

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bobbor bobbor requested a review from a team as a code owner August 27, 2025 11:41
@bobbor bobbor force-pushed the bobbor/api-rest/feat/relativeURL branch from 78cd9cd to 706f0c0 Compare August 27, 2025 12:49
@bobbor bobbor requested a review from a team as a code owner August 27, 2025 13:19
@bobbor bobbor force-pushed the bobbor/api-rest/feat/relativeURL branch from 7610a79 to 8358d9f Compare August 29, 2025 10:04
@bobbor bobbor force-pushed the bobbor/api-rest/feat/relativeURL branch from 8358d9f to 594d491 Compare September 1, 2025 14:16
@bobbor bobbor merged commit 77443c8 into main Sep 2, 2025
36 checks passed
@bobbor bobbor deleted the bobbor/api-rest/feat/relativeURL branch September 2, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants