fix(api-graphql): trigger WebSocket reconnection on auth errors #14569
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the critical issue where DataStore sync silently fails after token expiration, causing users to miss real-time updates while Hub events incorrectly report success. Resolves aws-amplify#12954 The `disconnectionHandler` in sync/index.ts only handled specific disconnect messages but not authentication errors. When tokens expired after ~12-24 hours: - Sync processor logged "Sync processor retry error: No current user" - WebSocket subscriptions silently failed - Hub events still reported "syncQueriesReady" - Outbound mutations worked but inbound subscriptions were dead Extended `disconnectionHandler` to detect authentication-related errors and trigger proper socket disconnection/reconnection with refreshed tokens. Added detection for authentication error messages: - "No current user" - Token expired/invalid - "Unauthorized" - Generic auth failure - "Token expired" - Explicit token expiration - "NotAuthorizedException" - Cognito auth failure When detected, the handler: 1. Logs a warning for debugging 2. Calls `datastoreConnectivity.socketDisconnected()` to force reconnection 3. Allows DataStore to re-establish subscriptions with refreshed tokens Tested with reproduction steps from issue: 1. Leave app idle for >12 hours with auth enabled 2. Wake computer/return to app 3. Verify subscriptions reconnect properly 4. Confirm real-time updates are received This ensures users don't miss critical real-time updates in production apps.
3 tasks
When subscriptions receive authentication errors (token expired, unauthorized, etc.), close the WebSocket connection to force reconnection with fresh auth tokens. This ensures subscriptions resume after extended idle periods or device sleep/wake cycles. Fixes aws-amplify#12954
anivar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the critical issue where DataStore subscriptions silently fail after authentication tokens expire, causing users to miss real-time updates.
Resolves #12954
Problem
After extended idle periods or device sleep/wake cycles (~12-24 hours):
Root Cause
The WebSocket provider doesn't detect authentication errors in subscription messages to trigger reconnection with fresh tokens. When a subscription receives an auth error (UnauthorizedException, Token expired, etc.), it simply errors out without forcing the WebSocket to reconnect.
Solution
Enhanced the WebSocket provider's error handling to:
UnauthorizedException/Unauthorized(error types)Token expired/NotAuthorizedException(error messages)401/403The DataStore's disconnectionHandler already has auth error detection from a previous attempt, so this completes the fix by ensuring the WebSocket layer properly handles token expiration.
Testing
Reproduced and verified fix using steps from issue:
@auth(rules: [{allow: owner}]))Code Changes
packages/api-graphql/src/Providers/AWSWebSocketProvider/index.tsImpact
Critical fix for production applications, especially:
As reported by @alex-breen: "leading to data loss on an add request (amplify js doesn't throw an error, but sync fails to write, but app doesn't know this, so data is lost)"
Related Issues