fix false-positives on number type changes #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarikana
force-pushed
the
fix-number-type-false-positive
branch
from
b89a016 to
1b1a22f
Compare
zhaomicx
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Number type changes which add or remove trailing zeroes(ex:- 1 -> 1.0) in resource schema currently lead to a runtime error during Stateful check:
"Comparing incoming context with literals or dynamic results wasn't possible PathAwareValues are not comparable int, float"from cfn-guard here.resource-schema-guard-rail should not report that as a diff to cfn-guard in the first place.
Description of changes:
Set parameter
ignore_type_in_groupsinDeepDiffto ignore number type changes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.