Skip to content

chore: improve controller build script to pull latest tags #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

Issue #, if available:

Description of changes:
This will ensure we don't accidentally push changes if the PRs
are not up to date. Sometimes you would fetch and rebase the
changes from upstream, but the tags for some reason
always stay behind.

This change ensures the tags are going to be up to date whenever
you generate the controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This will ensure we don't accidentally push changes if the PRs
are not up to date
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler April 11, 2025 21:53
Copy link

ack-prow bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ack-prow bot commented Apr 11, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 1508900 link false /test verify-attribution
s3-olm-test 1508900 link false /test s3-olm-test
documentdb-controller-test 1508900 link true /test documentdb-controller-test
acm-controller-test 1508900 link true /test acm-controller-test
cloudfront-controller-test 1508900 link true /test cloudfront-controller-test
apigatewayv2-controller-test 1508900 link true /test apigatewayv2-controller-test
dynamodb-controller-test 1508900 link true /test dynamodb-controller-test
efs-controller-test 1508900 link true /test efs-controller-test
eventbridge-controller-test 1508900 link true /test eventbridge-controller-test
ecr-controller-test 1508900 link true /test ecr-controller-test
eks-controller-test 1508900 link true /test eks-controller-test
ec2-controller-test 1508900 link true /test ec2-controller-test
lambda-controller-test 1508900 link true /test lambda-controller-test
iam-controller-test 1508900 link true /test iam-controller-test
pipes-controller-test 1508900 link true /test pipes-controller-test
prometheusservice-controller-test 1508900 link true /test prometheusservice-controller-test
s3-controller-test 1508900 link true /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant