test: Add non-ascii characters test. #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karthik Bekal Pattathana <[email protected]>
Contributor
Author
We can override merge even with this check failing. We should plan on refactoring all the tests in this folder so that we re-use the code amongst the tests instead of rewriting. But it is out of scope for this PR. |
crowecawcaw
approved these changes
Dec 23, 2024
joel-wong-aws
approved these changes
Dec 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this test until OpenJobDescription/openjd-adaptor-runtime-for-python#171 is merged
What was the problem/requirement? (What/Why)
Adding a test to ensure that scene files with Non-ASCII characters work successfully.
What was the solution? (How)
Just adds a test which contains scene file names as well as attachments containing Non-ASCII characters.
What is the impact of this change?
This should help detect if we stop supporting non-ASCII characters.
How was this change tested?
Tested it by submitting the scene file to Deadline Cloud and receive successful renders.
Yes
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Yes
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.