Skip to content

fix: Add timeout for Nuke jobs on EnvEnter/Exit #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarinMaksutaj wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

fix: Add timeout for Nuke jobs on EnvEnter/Exit #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/deadline/nuke_submitter/default_nuke_job_template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ steps:
- file://{{ Env.File.initData }}
cancelation:
mode: NOTIFY_THEN_TERMINATE
timeout: 600
Copy link
Contributor

@epmog epmog Mar 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this interact with the existing settings for Nuke timeouts? https://github.com/aws-deadline/deadline-cloud-for-nuke/blob/mainline/src/deadline/nuke_submitter/deadline_submitter_for_nuke.py#L59

If a user specifies no timeouts, do they now get a default of 10 minutes for the env enter? Related, but I believe if not specified then EnvExit will now have a default due to changes in OpenJobDescription.

Copy link
Contributor Author

@MarinMaksutaj MarinMaksutaj Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought was that by default now it would've been set to 10 minutes (time which I based it off from the other DCCs, for example Cinema4D). Anywhere else we are setting this value that I'm not aware?

Copy link
Contributor Author

@MarinMaksutaj MarinMaksutaj Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I see what you mean now, there are default values on the GUI toggles themselves, and those would overwrite the default values on the template.. In that case we could always adjust those values to 10 minutes as well.

Copy link
Contributor

@epmog epmog Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely try out the existing timeout controls and see what behaviour we see when we change values, or choose to not use timeouts. What we end up doing should be clear and expected by the users.

Copy link
Contributor

@npmacl npmacl Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long does this action take normally?

Copy link
Contributor Author

@MarinMaksutaj MarinMaksutaj Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 minutes seems like a generous number, not too sure how long it actually takes, but cinema4D has the same value specified for both actions.

onExit:
command: NukeAdaptor
args:
Expand All @@ -117,6 +118,7 @@ steps:
- '{{ Session.WorkingDirectory }}/connection.json'
cancelation:
mode: NOTIFY_THEN_TERMINATE
timeout: 600
script:
embeddedFiles:
- name: runData
Expand Down