Skip to content

Conversation

@moorec-aws
Copy link
Contributor

What was the problem/requirement? (What/Why)

Python 3.13.11 for mac and linux include:

PYZ.pyz/_sysconfigdata__linux_x86_64-linux-gnu
PYZ.pyz/_sysconfigdata__darwin_darwin

These will be safe to allow list. These are python configurations that will fall within the python licensing.

What was the solution? (How)

Add them to the allow list.

What is the impact of this change?

How was this change tested?

Installed 3.13.11 and confirmed validation works:

(.venv-validation) moorec@bcd074a5e7fe deadline-cloud % python scripts/pyinstaller/validate.py
Extracting: /Users/moorec/workplace/github/deadline-cloud/dist/deadline-client-exe.zip
Extracting: /var/folders/db/q6zs6kr125l801158wnx79100000gq/T/tmp8c7pexw8/deadline
Extracting: /var/folders/db/q6zs6kr125l801158wnx79100000gq/T/tmpgiybvzw4/PYZ.pyz
Extracting: /var/folders/db/q6zs6kr125l801158wnx79100000gq/T/tmp8c7pexw8/_internal/base_library.zip
Found file deadline/PYZ.pyz/_sysconfigdata__darwin_darwin which was not included in the allowlist

(.venv-validation) moorec@bcd074a5e7fe deadline-cloud % python scripts/pyinstaller/validate.py
Extracting: /Users/moorec/workplace/github/deadline-cloud/dist/deadline-client-exe.zip
Extracting: /var/folders/db/q6zs6kr125l801158wnx79100000gq/T/tmprqzijx96/deadline
Extracting: /var/folders/db/q6zs6kr125l801158wnx79100000gq/T/tmp4li3yf4j/PYZ.pyz
Extracting: /var/folders/db/q6zs6kr125l801158wnx79100000gq/T/tmprqzijx96/_internal/base_library.zip
Validation passed

Was this change documented?

Yes

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change?

No

Does this change impact security?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@moorec-aws moorec-aws requested a review from a team as a code owner December 31, 2025 20:41
@github-actions github-actions bot added the waiting-on-maintainers Waiting on the maintainers to review. label Dec 31, 2025
@sonarqubecloud
Copy link

@moorec-aws moorec-aws merged commit d5d8be4 into aws-deadline:mainline Dec 31, 2025
28 checks passed
@moorec-aws moorec-aws deleted the moorec/add-to-validation-allowlist branch December 31, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants