feat(c2cuc): add functionality for updating configuration of other components#1577
Draft
aws-kevinrickard wants to merge 3 commits intoc2c-update-configurationfrom
Draft
feat(c2cuc): add functionality for updating configuration of other components#1577aws-kevinrickard wants to merge 3 commits intoc2c-update-configurationfrom
aws-kevinrickard wants to merge 3 commits intoc2c-update-configurationfrom
Conversation
…teConfiguration field
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against c391d69 |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against c391d69 |
MikeDombo
reviewed
Feb 9, 2024
| String.join(", ", request.getValueToMerge().keySet()) | ||
| )); | ||
|
|
||
| Topics serviceTopics = kernel.findServiceTopic(targetServiceName); |
Member
There was a problem hiding this comment.
you need to check for authorization before starting to do the lookup and applying changes. Please do that in this change.
…n and UpdateConfiguration
c391d69 to
d55536b
Compare
Member
Author
|
Authorization changes still WIP, setting this PR to draft for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
GG-44771
GG-44748
Description of changes:
Key not found, so I updated it to also use the error message I introduced for UpdateConfiguration when a component is not found.Why is this change necessary:
As a developer building components to run in Greengrass, I want to update a component A's config from an other component B, so that B can adjust the behavior of A at runtime.
How was this change tested:
Any additional information or context required to review the change:
c2c-update-configuration)Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.