Stage RUM 2.0 for release #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: replace ResourceEvent with W3C compliant PerformanceResourceTimingEvent (breaking) * fix: firefox * chore: add version 2.0.0 * chore: dispatch omitted resource fields to event bus * chore: remove internalMessage * chore: cleanup * fix: flaky ms edge integ test * chore: add unit tests for event type validation * fix: integ test port * fix: flaky ms edge integ test * chore: add links to stylesheet filetype * chore: test * fix: disable flaky tests on edge * chore: add integ test for value check * fix: port * chore: remove server timing for now * chore: observe() * chore: restore ignore comment * chore: add length check to integ test * Revert "chore: add length check to integ test" This reverts commit 5061775. * chore: change title to PerformanceResourceTimingEvent * chore: remove version and add enum for initiatorType * fix: isPutRumEvents() * Revert "fix: isPutRumEvents()" This reverts commit 3e29234. * chore: add initiatorType "other" * chore: add runtime check for resource * chore: restore name * chore: restore name * Add a wait to see if it fixes integ tests --------- Co-authored-by: Quinn Hanam <[email protected]>
qhanam
approved these changes
Jul 16, 2024
|
With this change, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #489 and #494 into mainline in order to stage RUM 2.0 for release. When approved, I will do a FF merge to preserve the above two commits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.