Skip to content

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 8, 2025

Please provide the issue number

Issue number: closes #1031

Summary

Changes

This pull request fixes a regression introduced when we added a new way to create subsegments.

User experience

Fluent API should work

        Tracing.WithSubsegment("LoggingResponse",
            subsegment =>
            {
                subsegment.AddAnnotation("AccountId", apigwProxyEvent.RequestContext.AccountId);
                subsegment.AddMetadata("LookupRecord", lookupRecord);
            });

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added area/tracing Core tracing utility tests labels Oct 8, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 8, 2025
@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.11%. Comparing base (b060344) to head (709ef3f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1032      +/-   ##
===========================================
- Coverage    78.12%   78.11%   -0.01%     
===========================================
  Files          298      298              
  Lines        12003    12012       +9     
  Branches      1441     1443       +2     
===========================================
+ Hits          9377     9383       +6     
- Misses        2163     2165       +2     
- Partials       463      464       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Oct 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracing Core tracing utility bug Unexpected, reproducible and unintended software behaviour size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: fix tracing subsegment exception when using fluent api

1 participant