Skip to content

chore: bump biome formatter to next major & reformat #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR manually bumps @biomejs/biome to the latest version (2.x) which constitutes a major release upgrade for us since we were stuck at 1.x.

The upgrade introduces a couple new rules that are a good thing for the project, but that required some manual attention. The changes focus almost exclusively on import sorting and unused variables.

Since the PR diff is very big, I tried to address each package in a dedicated commit and I suggest reviewers to use the dropdown at the top-left of the PR view to select the commits while reviewing to limit the number of files.

Aside from that, apologies in advance for the big PR, splitting the work in multiple PRs would've required changes to the CI to support both versions at the same time and it wasn't worth it.

I also don't expect reviewers to look at every single file, but rather get a gist of the changes and review it as a whole, knowing that the tests are still passing.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4144


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from svozza July 7, 2025 17:19
@dreamorosi dreamorosi self-assigned this Jul 7, 2025
@boring-cyborg boring-cyborg bot added automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jul 7, 2025
@svozza
Copy link
Contributor

svozza commented Jul 8, 2025

I tried to address each package in a dedicated commit and I suggest reviewers to use the dropdown at the top-left of the PR view to select the commits while reviewing to limit the number of files

Thanks for this, made reviewing the changes much easier.

Copy link

sonarqubecloud bot commented Jul 8, 2025

@dreamorosi dreamorosi requested a review from svozza July 8, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: bump biome formatter to next major
2 participants