-
Notifications
You must be signed in to change notification settings - Fork 175
feat(event-handler): Add includeRouter and context sharing support to AppSync GraphQL resolver #4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(event-handler): Add includeRouter and context sharing support to AppSync GraphQL resolver #4457
Conversation
* @param handler - The exception handler function. | ||
*/ | ||
private registerErrorHandler( | ||
#registerErrorHandler( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to follow the convention of private methods in this project. I missed this in my last PR.
We have updated the linting rules of the project to make them a bit stricter - this should make reviewing contributions easier on both sides since you can now catch issues both with pre-commit hooks and CI here on the PR. You might need to rebase and address the issues in the new code to get the CI green. |
… enhanced merge functionality
…adjust tests accordingly
…AppSyncGraphQLResolver
1c4929f
to
2b40997
Compare
|
Summary
This PR adds the ability for router composition and sharing context data between routes
Changes
Follows the impmentation provided in the linked issue description.
includeRouter
method for router compositionappendContext
method for appending context that is shared with all the routessharedContext
, this is up for debateIssue number: closes #4131
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.