Repository navigation
prism-cli 1.19.2: say when a branch review has nothing to review, and offer the whole repo - #120
Merged
Merged
Conversation
… offer the whole repo - The branch card reads the branch review's scope from local git (the CLI's own diffBase/branchScope): upstream, else the remote default branch. Nothing new since it, or no base: say so, disable the branch Start, offer Review the whole repo instead (the --full action, with its guards). Counts uncommitted changes, which no review includes. - The drawer shows a branch review that exited 0 and saved no run as a neutral 'nothing to review', with the same offer. - CLI: 'No changes against <base>; nothing to review. To review the whole repo at HEAD, run with --full.' - GET /api/security-agent/scope?repo=<id>: one known repo, read-only git.
✅ PRISM Eval Gate -- PASSScore: 0.86 | Findings: 7 (0 high, 1 medium) Summary: No blocking issues. The main concern is the heuristic nothing outcome, which can mislabel a failed pending-record write. The rest are minor race, staleness and duplication points in the scope check.
✅ Secret scan -- no credentials found in this PR's commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prism-cli 1.19.2. Fixes a user-reported dead end on the Security Agent page.
What the user saw
The user started Code review of this branch and clicked Start another anyway. The drawer showed
exit 0andNo changes against origin/feat/receiver-tool-usage; nothing to review.No job ran, and the page gave no warning or next step, so it read as Security Agent refusing to run. The CLI was right: the branch had nothing new since its upstream.What changes
diffBase, shared now) and is read from local git only. With nothing new since that base, or no base at all, the card says so (Nothing new on <branch> since <upstream>; a branch review would have nothing to check), disables Start code review and offers Review the whole repo instead. It also counts uncommitted changes, which no review includes: "commit them first".--fullaction. The running and already-reviewed guards still apply.No changes against <base>; nothing to review. To review the whole repo at HEAD, run with --full.GET /api/security-agent/scope?repo=<id>serves only repo ids the last full answer listed. It runs read-only git in that repo, makes no AWS call, and returns no paths.Tests
npm test(aws guard): 880/880.security-branch-scope.test.tsuses real git and covers: up to date with the upstream, a dirty tree, a new commit, no upstream with a default branch, neither, and a detached HEAD.npm run docs:check: 0 problems.branchsuite, run with the fake aws, has three checks:Docs: USER_GUIDE (branch card, drawer, CLI message); CLI-REFERENCE version.