Repository navigation
prism-cli 1.20.1: threat-model drill-down header at the top, overview in its own card, safe markdown - #122
Open
Enclavet wants to merge 1 commit into
Open
prism-cli 1.20.1: threat-model drill-down header at the top, overview in its own card, safe markdown#122Enclavet wants to merge 1 commit into
Enclavet wants to merge 1 commit into
Conversation
… in its own card, safe markdown - The header's field list (.rundl) is a grid inside the .runhead grid; the long overview made the right column tens of thousands of pixels tall, the dl stretched to match and its rows spread the fields down the page. align-content/align-items start; the overview moves out of the header. - Overview card for threat models and pentests: first paragraph, Show full overview; markdown drawn with createElement/text nodes only (headings, paragraphs, lists, inline code, bold, fences/tables as pre; links and images as their text). - Threats show their affected components and assets; threat-model results save impactedAssets from now on.
✅ PRISM Eval Gate -- PASSScore: 0.93 | Findings: 4 (0 high, 0 medium) Summary: The overview renderer is safe: it uses text nodes only, with no innerHTML and no attributes, and assets are redacted before they are saved. The only issues are minor robustness, performance and duplic
✅ Secret scan -- no credentials found in this PR's commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prism-cli 1.20.1. Fixes the threat-model drill-down (
#security/run/<repo>/<id>-manual-security-threat-model) a user hit on live data.Root cause of the empty header
The header's field list (
.rundl, a grid) sits in the left cell of the.runheadgrid. The threat model's system overview (about 119,000 characters of markdown in the real result) was drawn in the right cell. That cell grew to about 25,000 px tall. The left cell stretched to match, and so did thedl, which spread its six rows across that height: Branch at 5,289 px, Account at 10,364 px, Job at 25,590 px. Only "Repo" was on screen. The data was all there: the result has the branch, commit, account, region, service times andservice_duration_s, andsecurityRunDetailalready maps them. Code reviews looked right only because they have no overview.What changes
align-items:start/align-content:start, and the overview is out of it. One layout for code reviews, threat models and pentests.markdown-lite.tsbuilds headings, paragraphs, lists, inline code and bold withcreateElementand text nodes only. It sets no attributes and never uses innerHTML. Fences and tables show as preformatted text; links show their text and images their alt text.impactedAssets(asassets) from now on; older results say they were not saved.Tests
npm test(aws guard): 884/884. Newthreat-model-drilldown.test.ts:<script>,<img onerror>, ajavascript:link, an image), produces text nodes and the allowed tags only, with no attributes and no URLs.npm run docs:check: 0 problems.tmdetailsuite seeds a real-shaped threat model (7 critical, 10 high, 1 medium; long markdown with hostile bits):Demo screenshots:
test-reports/threat-model-drilldown/(1280 light and dark, 390 dark).Docs: USER_GUIDE (a run's page); CLI-REFERENCE version.