Fix hardcoded AWS endpoint using CloudFormation pseudo parameter #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
commented
Sep 9, 2025
| @@ -1,32 +1,32 @@ | |||
| --- | |||
There was a problem hiding this comment.
FYI: This file used ^M newlines, which I converted using dos2unix apigw-http-api-lambda-dotnet-sam/template.yaml
joe4dev
commented
Sep 9, 2025
| ApiURL: | ||
| Description: API endpoint URL for Prod environment | ||
| Value: | ||
| Fn::Sub: https://${ServerlessRestApi}.execute-api.${AWS::Region}.${AWS::URLSuffix}/Prod/ |
There was a problem hiding this comment.
This line contains the only change, replacing amazonaws.com with ${AWS::URLSuffix}
joe4dev
commented
Sep 9, 2025
| @@ -270,7 +270,7 @@ Resources: | |||
| - - service | |||
| - !Ref ECSCluster | |||
| - !GetAtt ECSService.Name | |||
| RoleARN: !Sub arn:aws:iam::${AWS::AccountId}:role/aws-service-role/ecs.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_ECSService | |||
| RoleARN: !Sub arn:aws:iam::${AWS::AccountId}:role/aws-service-role/ecs.application-autoscaling.${AWS::URLSuffix}/AWSServiceRoleForApplicationAutoScaling_ECSService | |||
There was a problem hiding this comment.
Not an output URL (as most other changes), but likely still relevant
joe4dev
commented
Sep 9, 2025
| @@ -145,7 +145,7 @@ Resources: | |||
| from aws_synthetics.common import synthetics_logger as logger | |||
|
|
|||
| def main(): | |||
| url = "https://${RestApi}.execute-api.${AWS::Region}.amazonaws.com/${RestApi.Stage}" | |||
| url = "https://${RestApi}.execute-api.${AWS::Region}.${AWS::URLSuffix}/${RestApi.Stage}" | |||
There was a problem hiding this comment.
Special case: Not a direct output URL (as most other changes), but composed dynamically in a Selenium context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoded endpoints such as
amazonaws.comare incompatible with custom endpoint URLs (e.g.,AWS_ENDPOINT_URL): https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.htmlaws-us-govUsing the CloudFormation pseudo parameter
${AWS::URLSuffix}(https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/pseudo-parameter-reference.html#cfn-pseudo-param-urlsuffix) fixes this issue as demonstrated for the AWS SAM templates aws/aws-sam-cli-app-templates#525Issue #, if available: N/A
Description of changes: Replace hardcoded
amazonaws.comdomain intemplate.yamloutput value with${AWS::URLSuffix}. The parameter${AWS::URLSuffix}evaluates toamazonaws.comin most cases, but respects custom endpoint URLs used, for example, in emulators such as LocalStack.Disclaimer: I work for LocalStack
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.