Change ECS Agent log rollover defaults to size-based rotation #4776
+98
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
update-log-rollover
branch
2 times, most recently
from
1bfef12 to
050e301
Compare
sparrc
changed the title
- Change DEFAULT_ROLLOVER_TYPE from 'date' to 'size' - Change DEFAULT_MAX_FILE_SIZE from 10MB to 5MB - Update README.md documentation for ECS_LOG_ROLLOVER_TYPE and ECS_LOG_MAX_FILE_SIZE_MB - Fix unit tests to expect size-based rollover instead of date-based - Add test cases for explicit hourly rollover to maintain backward compatibility The reason for this change is to improve the situation where customers are pulling logs more than 24 hours after an issue has occured, and we are not able to troubleshoot it because there are no relevant logs available.
sparrc
force-pushed
the
update-log-rollover
branch
from
050e301 to
395818c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this change is to improve the situation where customers
are pulling logs more than 24 hours after an issue has occured, and we
are not able to troubleshoot it because there are no relevant logs
available.
Some metrics were pulled from our functional testing account to determine that this change should generally not negatively affect log retention in the case of a high-load instance, even in the case that debug logs are enabled.
With "debug" log level:
With "info" log level:
Testing
New tests cover the changes: no, modified existing unit tests
Description for the changelog
Enhancement: default to size-based log file rollover instead of hourly
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.