chore: changes in @aws-cdk/toolkit-lib should trigger CLI release
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
requested a deployment
to
integ-approval
GitHub Actions
Waiting
iliapolo
changed the title
@aws-cdk/toolkit-lib do not trigger CLI release @aws-cdk/toolkit-lib should trigger CLI release
rix0rrr
reviewed
Apr 14, 2025
| ]; | ||
|
|
||
| return transitiveFeaturesAndFixes(thisPkg, toolkitPackages.filter(name => name !== thisPkg)); | ||
| const manifest = require(`${__dirname}/packages/${thisPkg}/package.json`); |
There was a problem hiding this comment.
This will only work after synthesis.
So if we add a new dependency we need to do
npx projen
npx projen
To pick it up. Can't we do it another way?
| ...Object.keys(manifest.devDependencies ?? {}), | ||
| ])); | ||
|
|
||
| return transitiveFeaturesAndFixes(thisPkg, toolkitPackages.filter(name => name !== thisPkg && deps.includes(name))); |
There was a problem hiding this comment.
It's not really transitive this way, is it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the CLI depends on
@aws-cdk/toolkit-lib, it should be added to the releasable commits list.Also, the
transitiveToolkitPackagesfunction, which is used to determine the packages we trigger releases on, did not consider whether the specific toolkit package is actually a dependency of the provided package or not.This caused incorrect releases. For example:
cli-lib-alphawas released whentmp-toolkit-helperswas changed, even though it does not depend on it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license