chore: improve stability of tests by copying SSM Parameter Value #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`{Fn::GetAtt}` on an `AWS::SSM::Parameter` is eventually consistent. If
an SSM Parameter was just created in a stack deployment, the
`{Fn::GetAtt}` may sometimes fail with a "Parameter not found" error.
This causes ~2 canary failures per week (about 1% failure rate).
We don't actually need to `{Fn::GetAtt}` the value as we know what it is
(it is static, after all). Copy the same literal value into both places
to reduce the canary failure rate by a little bit, and add a test to
make sure the values don't accidentally drift apart.
Internal reference D259904064.
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
auto-merge was automatically disabled
September 1, 2025 10:06
Pull request was closed
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
- Coverage 82.82% 82.15% -0.68%
==========================================
Files 65 65
Lines 9509 9509
Branches 1120 1105 -15
==========================================
- Hits 7876 7812 -64
- Misses 1599 1664 +65
+ Partials 34 33 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otaviomacedo
approved these changes
Sep 1, 2025
rix0rrr
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{Fn::GetAtt}on anAWS::SSM::Parameteris eventually consistent. If an SSM Parameter was just created in a stack deployment, the{Fn::GetAtt}may sometimes fail with a "Parameter not found" error.This causes ~2 canary failures per week (about 1% failure rate).
We don't actually need to
{Fn::GetAtt}the value as we know what it is (it is static, after all). Copy the same literal value into both places to reduce the canary failure rate by a little bit, and add a test to make sure the values don't accidentally drift apart.Internal reference D259904064.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license