-
Notifications
You must be signed in to change notification settings - Fork 69
fix(cli): hotswap ECS flags result in SerializationException: STRING_VALUE cannot be converted to Integer
#973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change hotswap-ecs-minimum-healthy-percent, hotswap-ecs-maximum-healthy-percent, and hotswap-ecs-stabilization-timeout-seconds from string to expected type number type.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 72 72
Lines 10077 10077
Branches 1327 1327
=======================================
Hits 8840 8840
Misses 1212 1212
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing and really we should have a test case here demonstrating the error is fixed.
The PR #417 introduced extra hotswap flags. However, when used the flags yield serialisation errors like bellow because the expected type is a number not a string.
This PR changes hotswap-ecs-minimum-healthy-percent, hotswap-ecs-maximum-healthy-percent, and hotswap-ecs-stabilization-timeout-seconds from string to expected type number type.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license