Skip to content

Conversation

@dysosmus
Copy link
Contributor

@dysosmus dysosmus commented Dec 4, 2025

The PR #417 introduced extra hotswap flags. However, when used the flags yield serialisation errors like bellow because the expected type is a number not a string.

failed: SerializationException: STRING_VALUE cannot be converted to Integer

This PR changes hotswap-ecs-minimum-healthy-percent, hotswap-ecs-maximum-healthy-percent, and hotswap-ecs-stabilization-timeout-seconds from string to expected type number type.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Change hotswap-ecs-minimum-healthy-percent, hotswap-ecs-maximum-healthy-percent,
and hotswap-ecs-stabilization-timeout-seconds from string to expected type number type.
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.72%. Comparing base (4813f35) to head (742fe10).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files          72       72           
  Lines       10077    10077           
  Branches     1327     1327           
=======================================
  Hits         8840     8840           
  Misses       1212     1212           
  Partials       25       25           
Flag Coverage Δ
suite.unit 87.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing and really we should have a test case here demonstrating the error is fixed.

@mrgrain mrgrain added this pull request to the merge queue Jan 12, 2026
Merged via the queue into aws:main with commit 6c41e85 Jan 12, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants